nixos/nh: init #294923
nixos/nh: init #294923
Conversation
|
Idk why the bot adds the |
viperML
force-pushed
the
nh-module
branch
2 times, most recently
from
4daaf6a
to
f02b017
Compare
viperML
force-pushed
the
nh-module
branch
2 times, most recently
from
6b300a9
to
1c5e611
Compare
|
Fixed some issues resulting of not using the |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3619 |
All of them? |
| config = { | ||
| warnings = | ||
| if (!(cfg.clean.enable -> !config.nix.gc.automatic)) then [ | ||
| "programs.nh.clean.enable and nix.gc.automatic are both enabled. Please use one or the other to avoid conflict." |
There was a problem hiding this comment.
| "programs.nh.clean.enable and nix.gc.automatic are both enabled. Please use one or the other to avoid conflict." | |
| "programs.nh.clean.enable and nix.gc.automatic conflict with each other, please decide for one of them." |
There was a problem hiding this comment.
This is less correct than the original; what was the intention behind this suggestion?
| warnings = | ||
| if (!(cfg.clean.enable -> !config.nix.gc.automatic)) then [ |
There was a problem hiding this comment.
Shouldn't this be an assertion?
There was a problem hiding this comment.
Was suggested by @eclairevoyant before: #294923 (comment)
There was a problem hiding this comment.
I don't think we need to arbitrarily block settings if they don't actually conflict. Warning seems better IMO.
| { | ||
| assertion = cfg.clean.enable -> cfg.enable; | ||
| message = "programs.nh.clean.enable requires programs.nh.enable"; | ||
| } |
There was a problem hiding this comment.
Why not set this option to true?
There was a problem hiding this comment.
I don't think other modules work this way.
|
(oops) |
|
thanks |
This reverts commit 60c019a.
Description of changes
Mostly a copy of the upstream module: https://github.com/viperML/nh/blob/master/module.nix
Marking as draft to get reactions about it. I need to add the release notes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.