lib/tests: remove top-level with in lib/tests

[philiptaron]

Description of changes

Using with at a top-level scope is an anti-pattern. The tracking issue is #208242. This is a pure refactor: there is no functional change contained in this PR.

I used the refactor strategy that looks for the uses of names coming from lib.

This PR changes the files that used top-level with lib; and with import ...; in the lib/tests/ directory.

Things done

• Tested, as applicable:
  • nix-instantiate --strict --eval lib/tests/misc.nix
  • lib/tests/modules.sh
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/removing-most-uses-of-top-level-with/41233/1

[liff]

The lib here is from the set pattern right above, not from the top-level, so should this perhaps remain unchanged?

[philiptaron]

I think it's clearer, since instead of two ways of referring to the same symbol, there's just one.

And, it turns out, it's also more performant. That doesn't matter in this file, but as a practice, it's good, in my judgement.

[roberth]

In general, this would only be relevant when combining two versions of the module system.
On top of that, this is just a test, with no other version of lib in sight.