Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetryPlugins.poetry-plugin-poeblix: init at 0.10.0 #295651

Merged
merged 2 commits into from Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
Expand Up @@ -7720,6 +7720,12 @@
matrix = "@chris:netsoj.nl";
name = "Chris Josten";
};
hennk = {
email = "henning.kiel@gmail.com";
github = "hennk";
githubId = 328259;
name = "Henning Kiel";
};
henrikolsson = {
email = "henrik@fixme.se";
github = "henrikolsson";
Expand Down
1 change: 1 addition & 0 deletions pkgs/tools/package-management/poetry/default.nix
Expand Up @@ -30,6 +30,7 @@ let
poetry-audit-plugin = callPackage ./plugins/poetry-audit-plugin.nix { };
poetry-plugin-export = callPackage ./plugins/poetry-plugin-export.nix { };
poetry-plugin-up = callPackage ./plugins/poetry-plugin-up.nix { };
poetry-plugin-poeblix = callPackage ./plugins/poetry-plugin-poeblix.nix { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
poetry-plugin-poeblix = callPackage ./plugins/poetry-plugin-poeblix.nix { };
poeblix = callPackage ./plugins/poeblix.nix { };

and even before that it wasn't sorted alphabetically.

};

# selector is a function mapping pythonPackages to a list of plugins
Expand Down
@@ -0,0 +1,37 @@
{ lib
, buildPythonPackage
, fetchFromGitHub
, poetry-core
}:

buildPythonPackage rec {
pname = "poetry-plugin-poeblix";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pname = "poetry-plugin-poeblix";
pname = "poeblix";

That's what it's called on PyPI.

version = "0.10.0";
pyproject = true;

src = fetchFromGitHub {
owner = "spoorn";
repo = "poeblix";
rev = "refs/tags/${version}";
hash = "sha256-TKadEOk9kM3ZYsQmE2ftzjHNGNKI17p0biMr+Nskigs=";
};

postPatch = ''
sed -i '/poetry =/d' pyproject.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sed -i '/poetry =/d' pyproject.toml

Add poetry to buildInputs.

'';

nativeBuildInputs = [
poetry-core
];

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Please run the tests.

pythonImportsCheck = ["poeblix"];

meta = with lib; {
changelog = "https://github.com/spoorn/poeblix/releases/tag/${src.rev}";
description = "Poetry Plugin that adds various features that extend the poetry command such as building wheel files with locked dependencies, and validations of wheel/docker containers";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long

license = licenses.mit;
homepage = "https://github.com/spoorn/poeblix";
maintainers = with maintainers; [ hennk ];
};
}