Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.base64io: 1.0.3 -> 1.0.3-unstable-2023-10-30 #296018

Merged

Conversation

anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Mar 14, 2024

Fixes the base64io build for Python 3.12 on Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/python312Packages.base64io.x86_64-linux

Diff: aws/base64io-python@1.0.3...6048175

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel anthonyroussel changed the title python312Packages.base64io: 1.0.3 -> unstable-2023-10-30 python312Packages.base64io: 1.0.3 -> 1.0.3-unstable-2023-10-30 Mar 14, 2024
@anthonyroussel
Copy link
Member Author

anthonyroussel commented Apr 5, 2024

@ofborg build python312Packages.base64io python311Packages.base64io

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3749

@arduano
Copy link
Contributor

arduano commented Apr 8, 2024

Result of nixpkgs-review pr 296018 run on x86_64-linux 1

2 packages failed to build:
  • aws-encryption-sdk-cli
  • aws-encryption-sdk-cli.dist
4 packages built:
  • python311Packages.base64io
  • python311Packages.base64io.dist
  • python312Packages.base64io
  • python312Packages.base64io.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1591

@SuperSandro2000 SuperSandro2000 merged commit d8b7917 into NixOS:master Apr 17, 2024
28 checks passed
@anthonyroussel anthonyroussel deleted the fix-base64io-for-python312 branch April 18, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants