Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impressive: fixes and improvements #29609

Merged
merged 1 commit into from
Sep 21, 2017
Merged

impressive: fixes and improvements #29609

merged 1 commit into from
Sep 21, 2017

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Sep 20, 2017 •
edited
Loading

Motivation for this change
  • Fix finding SDL (would previously fail unless gcc was in environment) (fixes Impressive broken #23980)
  • Use ghostscript rather than xpdf for rendering as it has a slightly
    smaller closure
  • Fix broken link for reasoning behind name change
  • Add self to maintainers
  • Add reference to DejaVu fonts so it can always find the OSD fonts
  • Install manpage into correct location
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @FRidh

@lheckemann
impressive: fixes and improvements
05101d3 
- Fix finding SDL (would previously fail unless gcc was in environment)
- Use ghostscript rather than xpdf for rendering as it has a slightly
  smaller closure
- Fix broken link for reasoning behind name change
- Add self to maintainers
- Add reference to DejaVu fonts so it can always find the OSD fonts
- Install manpage into correct location
@Mic92 Mic92 merged commit eaac347 into NixOS:master Sep 21, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

Thanks. Also ported to 17.09.

@lheckemann lheckemann deleted the impressive-fixes branch September 21, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impressive broken
2 participants
@lheckemann @Mic92