Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.diffimg: fix test #296323

Merged
merged 1 commit into from Mar 17, 2024
Merged

python312Packages.diffimg: fix test #296323

merged 1 commit into from Mar 17, 2024

Conversation

evils
Copy link
Member

@evils evils commented Mar 16, 2024

python 3.12 seems to yield a very slightly different result
change is the least significant digit of a ratio, seems safe

and upgrade to --replace-warn while i'm here

found via #291134 but shouldn't block it

affected line:
https://github.com/nicolashahn/diffimg/blob/b82f0bb416f100f9105ccccf1995872b29302461/diffimg/test.py#L80

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

python 3.12 seems to yield a very slightly different result
  change is the least significant digit of a ratio, seems safe

and upgrade to --replace-warn while i'm here
@kirillrdy
Copy link
Member

Result of nixpkgs-review pr 296323 run on x86_64-linux 1

5 packages failed to build:
  • kicad-unstable
  • kicad-unstable-small
  • python312Packages.kicad
  • python312Packages.pcbnew-transition
  • python312Packages.pcbnew-transition.dist
19 packages built:
  • kicad
  • kicad-small
  • kicad-testing
  • kicad-testing-small
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist
  • python311Packages.diffimg
  • python311Packages.diffimg.dist
  • python311Packages.kicad
  • python311Packages.pcbnew-transition
  • python311Packages.pcbnew-transition.dist
  • python311Packages.pytest-image-diff
  • python311Packages.pytest-image-diff.dist
  • python312Packages.diffimg
  • python312Packages.diffimg.dist
  • python312Packages.pytest-image-diff
  • python312Packages.pytest-image-diff.dist

@kirillrdy kirillrdy merged commit d09d5af into NixOS:master Mar 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants