Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dipc: init at 1.0.0 #296404

Merged
merged 1 commit into from Mar 27, 2024
Merged

dipc: init at 1.0.0 #296404

merged 1 commit into from Mar 27, 2024

Conversation

ByteSudoer
Copy link
Contributor

@ByteSudoer ByteSudoer commented Mar 16, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
@ByteSudoer
Copy link
Contributor Author

@lolbinarycat Thank you for pointing out to those typos. Everything has been fixed as suggested.

Copy link
Contributor

@lolbinarycat lolbinarycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more issues

pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
@ByteSudoer
Copy link
Contributor Author

Fixed. It 's quite strange that the formatter could not delete out those extra empty lines. Thx again

@lolbinarycat
Copy link
Contributor

ok, looks good, do you think you could squash the commits and make them fit the commit conventions?

there should be one commit adding yourself as a maintainer, and one commit adding the package.

@ByteSudoer
Copy link
Contributor Author

ByteSudoer commented Mar 17, 2024

@lolbinarycat I think squashing the commits would require a new pull request and that would force the rebuild on every task for the CI/CD chain. How would you recommend proceeding from here.
image

@lolbinarycat
Copy link
Contributor

if you use git push --force it will update the existing PR (however, the old commits will disappear, so make sure everything is correct before you do)

the hard part is getting your local state setup properly, apparently this is doable with git rebase -i. personally i always ended up doing things manually with git format-patch and git am

before trying to rebase, you can use git branch -c to create a backup of the pre-rebase branch.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3656

pkgs/by-name/di/dipc/package.nix Outdated Show resolved Hide resolved
@quantenzitrone
Copy link
Contributor

quantenzitrone commented Mar 20, 2024

Result of nixpkgs-review pr 296404 run on x86_64-linux 1

1 package failed to build:
  • dipc
$ nix build --nix-path nixpkgs=/home/qz/.cache/nixpkgs-review/pr-296404/nixpkgs nixpkgs-overlays=/tmp/tmpews7ak4l --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed -f /home/qz/.cache/nixpkgs-review/pr-296404/build.nix
error: hash mismatch in fixed-output derivation '/nix/store/fkjxyv7lqjv0cm7h4d751qpzvb935imc-dipc-1.0.0-vendor.tar.gz.drv':
         specified: sha256-t+G8eQufZPge9vyz6jdET7PZ76eQkCyPt0m2CYzIuD0=
            got:    sha256-XQ85T64K1NLdSOtAFr0XluvFNTaHzoWKxoQtBQ+uSKQ=
error: 1 dependencies of derivation '/nix/store/7hkqac2pb5dxwr2xnqcc9ffmrnnkb85x-dipc-1.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jmrn26wasxcc5kh6dlccx27l8chprigd-review-shell.drv' failed to build

@ByteSudoer
Copy link
Contributor Author

ByteSudoer commented Mar 20, 2024

Thx for pointing that out. It has been fixed

@quantenzitrone
Copy link
Contributor

quantenzitrone commented Mar 20, 2024

Result of nixpkgs-review pr 296404 run on x86_64-linux 1

1 package built:
  • dipc

also confirmed that it works

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the commit history according to the contributing guide.

@ByteSudoer
Copy link
Contributor Author

@SuperSandro2000 I squashed the commits based on the descriptions in the contribution guidelines. Sorry for the inconvenience. I will re-request a review. Thx

@ByteSudoer ByteSudoer force-pushed the add-dipc branch 2 times, most recently from f5669c6 to ba1187e Compare March 25, 2024 20:25
@SuperSandro2000 SuperSandro2000 merged commit e86a737 into NixOS:master Mar 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants