New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
dipc: init at 1.0.0 #296404
dipc: init at 1.0.0 #296404
Conversation
@lolbinarycat Thank you for pointing out to those typos. Everything has been fixed as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few more issues
Fixed. It 's quite strange that the formatter could not delete out those extra empty lines. Thx again |
ok, looks good, do you think you could squash the commits and make them fit the commit conventions? there should be one commit adding yourself as a maintainer, and one commit adding the package. |
@lolbinarycat I think squashing the commits would require a new pull request and that would force the rebuild on every task for the CI/CD chain. How would you recommend proceeding from here. |
if you use the hard part is getting your local state setup properly, apparently this is doable with before trying to rebase, you can use |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3656 |
Result of 1 package failed to build:
$ nix build --nix-path nixpkgs=/home/qz/.cache/nixpkgs-review/pr-296404/nixpkgs nixpkgs-overlays=/tmp/tmpews7ak4l --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed -f /home/qz/.cache/nixpkgs-review/pr-296404/build.nix
error: hash mismatch in fixed-output derivation '/nix/store/fkjxyv7lqjv0cm7h4d751qpzvb935imc-dipc-1.0.0-vendor.tar.gz.drv':
specified: sha256-t+G8eQufZPge9vyz6jdET7PZ76eQkCyPt0m2CYzIuD0=
got: sha256-XQ85T64K1NLdSOtAFr0XluvFNTaHzoWKxoQtBQ+uSKQ=
error: 1 dependencies of derivation '/nix/store/7hkqac2pb5dxwr2xnqcc9ffmrnnkb85x-dipc-1.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jmrn26wasxcc5kh6dlccx27l8chprigd-review-shell.drv' failed to build |
Thx for pointing that out. It has been fixed |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up the commit history according to the contributing guide.
@SuperSandro2000 I squashed the commits based on the descriptions in the contribution guidelines. Sorry for the inconvenience. I will re-request a review. Thx |
f5669c6
to
ba1187e
Compare
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.