Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

yt-dlg: init at 1.8.5 #296530

Merged
merged 1 commit into from
Mar 17, 2024
Merged

yt-dlg: init at 1.8.5 #296530

merged 1 commit into from
Mar 17, 2024

Conversation

quantenzitrone
Copy link
Contributor

Description of changes

closes #69334

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@quantenzitrone
Copy link
Contributor Author

I don't understand why prev.fetchPypi doesn't work, but final.fetchPypidoes.
I should have tested building it locally before pushing it.

@quantenzitrone
Copy link
Contributor Author

huh?!? final worked locally for me

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3649

@SuperSandro2000 SuperSandro2000 merged commit 33598e7 into NixOS:master Mar 17, 2024
28 of 29 checks passed
@quantenzitrone quantenzitrone deleted the yt-dlg branch March 17, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package youtube-dl-gui
3 participants