New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zsh zhooks plugin #296562
base: master
Are you sure you want to change the base?
Add zsh zhooks plugin #296562
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3645 |
262dc15
to
215bad7
Compare
Thanks! All of the suggestions have been fixed. One thing I remembered is that things should go into I also just remembered there is a push to not use |
@SuperSandro2000 can you take another review pass if you find the time? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3698 |
Your commit is breaking Commit Conventions. Please rebase. In your case reword 215bad7 to |
Please rename your PR title to |
883e162
to
e473201
Compare
3861041
to
5fd3a4e
Compare
5fd3a4e
to
b3f7e72
Compare
Thanks @DontEatOreo. Just noted the one difference between our nixfmt-rfc-style formatting, but otherwise should all be addressed. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1630 |
Description of changes
Add myself to maintainers list and add a new simple zsh plugin as my first package.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.