nixos/resolvconf: add option "trust-ad" when useLocalResolver is enabled
#296584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbdd0121
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
"trust-ad" says that if the recursive DNS resolver says DNSSEC is validated, then trust that it actually does so. This is not the default because doing so would mean that (1) you trust the DNS server and (2) you trust the network path to the DNS resolver (since you can't verify that UDP packets are not tampered with). For local resolver both of them are satisfied.
See also the setting from systemd-resolvd: https://github.com/systemd/systemd/blob/36ca167220eb5d89f69478aeff96f8d0b6ca438b/src/resolve/resolv.conf#L18
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1580 |
Janik-Haag
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #295804
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.