nixos/movim: init, movim: additions + patches #296641
Conversation
toastal
force-pushed
the
movim-service
branch
20 times, most recently
from
4679475
to
a54460d
Compare
toastal
force-pushed
the
movim-service
branch
4 times, most recently
from
a88f8f6
to
7a7d4ec
Compare
|
yoyo, is this ready for merging? I guess we can also fix stuff later? |
|
Actually it is ready to go enough at this point. I was going to put it off thinking the upstream maintainer would have cut a release sooner as their in-chat language seemed to indicate as much, but at this commit is fine too & could point to the upcoming release soon enough in the future as everything I really wanted/needed has been merged into their default branch already.
I have have a slight issue an my machine with public/private posts but I’m 90% sure this is an issue in my XMPP server configuration, not in the app itself or this module.
All pushes of late were just Nixpkgs rebases.
--
toastal ไข่ดาว | https://toast.al
PGP: 7944 74b7 d236 dab9 c9ef e7f9 5cce 6f14 66d4 7c9e
|
toastal
force-pushed
the
movim-service
branch
4 times, most recently
from
44c385a
to
df39176
Compare
Version is ‘weird’ to deal with the composer script
| ++ lib.optional cfg.database.createLocally dbService; | ||
| }; | ||
|
|
||
| tmpfiles.settings = with cfg; { |
There was a problem hiding this comment.
| tmpfiles.settings = with cfg; { | |
| tmpfiles.settings.movil = with cfg; { |
you need to specify the filename/namespace also
There was a problem hiding this comment.
hmm… actually reading about it & many of these files aren’t actually temporary, but I initially copied from a different, similar PHP project. One sec.
There was a problem hiding this comment.
Looks like others that are linking out of their builds like this are still using tmpfiles. Not 100% sure, but I did see most are using "10-${pname}"-like entries
|
@toastal: Good job! |
|
@Neustradamus Thanks. Are you using it to success? And does it meet your needs? |
|
@toastal: I do not use your code but it is a good news for XMPP users in the World :) |
|
Roger. @Neustradamus if you ever need anything, reach out on XMPP |
Description of changes
Added Movim as a service. This includes a few awaiting-review patches to upstream on Movim’s Microsoft GitHub proprietary code forge--some are for making NixOS work better & I needed to move to the latest commit to avoid the patches conflicts for:
Respect user agent font sizing movim/movim#1280Additionally:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project.
I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩