catppuccin-sddm: init at 1.0.0

[ElysaSrc]

Description of changes

Adding package catppuccin-sddm on nixpkgs, since we already have some other catppuccin official themes (gtk, plasma, icons etc...).

I've added options to the derivation to control the theme file (flavor, theme.conf options...).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[keenanweaver]

Result of nixpkgs-review pr 296682 run on x86_64-linux 1

1 package built:

• catppuccin-sddm

[keenanweaver]

Working well for me. This would also close #279136

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3669

[khaneliman]

Working well for me. This would also close #279136

#255808 as well

[ElysaSrc]

Force pushed the branch:

• Bumped to v1.0.0
• Using --replace-fail
• Cleaned up redundant substituteInPlace

[ElysaSrc]

Is there any issue remaining preventing this PR to be merged ?

[ElysaSrc]

Updated the branch, using kdePackages.callPackage instead of the libsForQt5.callPackage

[Aleksanaa]

You have to add runHook if you override phases. See https://nixos.org/manual/nixpkgs/unstable/#sec-stdenv-phases

Here are buildPhase and installPhase

[Sigmanificient]

Can you re-fetch master and rebase? Eval is failing and was fixed by #305609.

[ElysaSrc]

@Sigmanificient That should be ok

[pluiedev]

Shouldn't all new packages be using the pkgs/by-name convention, per RFC 140?

[ElysaSrc]

@pluiedev I'm sorry, I checked the RFC but didn't understand what I'm supposed to do ? Could you point me in a direction ? Thanks !

[pluiedev]

@pluiedev I'm sorry, I checked the RFC but didn't understand what I'm supposed to do ? Could you point me in a direction ? Thanks !

Move pkgs/data/themes/catppuccin-sddm/default.nix to pkgs/by-name/ca/catppuccin-sddm/package.nix, and remove the addition to pkgs/top-level/all-packages.nix

[ElysaSrc]

@pluiedev I'm sorry, I checked the RFC but didn't understand what I'm supposed to do ? Could you point me in a direction ? Thanks !

Move pkgs/data/themes/catppuccin-sddm/default.nix to pkgs/by-name/ca/catppuccin-sddm/package.nix, and remove the addition to pkgs/top-level/all-packages.nix

Sorry for the delay, made the changes, rebased on more recent master.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3917

[ribru17]

Thank you so much for this! Just wanted to note that when using this theme the settings.Theme.CursorTheme option for sddm is now ignored for me. Must those values be set in catppuccin-sddm's sddm.conf?