asciiquarium-transparent: unstable-2023-02-19 -> 1.3 #296976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantenzitrone
added
11.by: package-maintainer
and removed
11.by: package-maintainer
labels
quantenzitrone
force-pushed
the
asciiquarium-transparent
branch
from
6fabcf7
to
7b2292f
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3653 |
quantenzitrone
force-pushed
the
asciiquarium-transparent
branch
from
7b2292f
to
ac6bb20
Compare
| src = fetchFromGitHub { | ||
| owner = "nothub"; | ||
| repo = "asciiquarium"; | ||
| rev = "653cd99a611080c776d18fc7991ae5dd924c72ce"; | ||
| hash = "sha256-72LRFydbObFDXJllmlRjr5O8qjDqtlp3JunE3kwb5aU="; | ||
| rev = "${finalAttrs.version}"; |
There was a problem hiding this comment.
We don't need to string interpolate here
There was a problem hiding this comment.
oops
it is so common that versions have to be string interpolated because the tag is almost always called v${version}
i'll try to remember to fix it on the next update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.