Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackit-cli: init at 0.1.0-prerelease.2 #297245

Merged
merged 2 commits into from Mar 27, 2024

Conversation

DerRockWolf
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

One minor question

I have one question about how one should ideally handle a package with multiple binaries:
This package has multiple main packages (stackit & scripts), however end users are only interested in using stackit.
Therefore, I've used subPackages = [ "." ]; which only builds the desired package, but as a result of that it would be the only package for which tests are run (if it would actually have unit tests).

Should I use excludedPackages = [ "scripts" ]; instead of subPackages to build & test all packages?

Would it then be a good idea to add another test to passthru.tests which ensures that only the desired binaries (stackit) are included in the output?


Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3661

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/st/stackit-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/st/stackit-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/st/stackit-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/st/stackit-cli/package.nix Outdated Show resolved Hide resolved
@DerRockWolf
Copy link
Contributor Author

Thanks for the review @SuperSandro2000 鉂わ笍
I've incorporated your feedback.

Do you also have insights regarding my question (PR description) about multiple go main packages?

@DerRockWolf DerRockWolf changed the title stackit-cli: init at 0.1.0-apt-prerelease.3 stackit-cli: init at 0.1.0-prerelease.2 Mar 26, 2024
@SuperSandro2000 SuperSandro2000 merged commit da524b7 into NixOS:master Mar 27, 2024
25 of 26 checks passed
@DerRockWolf DerRockWolf deleted the add/stackit-cli branch March 27, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants