stackit-cli: init at 0.1.0-prerelease.2 #297245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
stackit-cli
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)One minor question
I have one question about how one should ideally handle a package with multiple binaries:
This package has multiple
main
packages (stackit
&scripts
), however end users are only interested in usingstackit
.Therefore, I've used
subPackages = [ "." ];
which only builds the desired package, but as a result of that it would be the only package for which tests are run (if it would actually have unit tests).Should I use
excludedPackages = [ "scripts" ];
instead ofsubPackages
to build & test all packages?Would it then be a good idea to add another test to
passthru.tests
which ensures that only the desired binaries (stackit
) are included in the output?Add a 馃憤 reaction to pull requests you find important.