Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influxdb sevice: make postStart test work with non-localhost configurations #29734

Merged
merged 2 commits into from
Sep 24, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Sep 24, 2017

Motivation for this change

The influxdb postStart script fails when its http port is bound to non-127.0.0.1 addresses ie.

  services.influxdb = {
    enable = true;
    extraConfig = {
      http = {
	bind-address = "192.168.1.10:8086";
      };
    };
  };

We currently default to :8086 and this change only uses 127.0.0.1 when the ip is missing from the user's configuraton.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

CC maintainers (of influxdb package): @offlinehacker @zimbatm

@zimbatm
Copy link
Member

zimbatm commented Sep 24, 2017

@womfoo sounds good, I refactored the change a bit

@womfoo
Copy link
Member Author

womfoo commented Sep 24, 2017

@zimbatm looks cleaner now. Thanks!

@zimbatm zimbatm merged commit 412fa16 into NixOS:master Sep 24, 2017
zimbatm pushed a commit that referenced this pull request Sep 24, 2017
…ations (#29734)

make postStart test work with non-localhost configurations

(cherry picked from commit 412fa16)
@womfoo womfoo deleted the fix/influxdb-non-localhost-poststart branch February 3, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants