Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagon: init @ 1.1.158 #297736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

diagon: init @ 1.1.158 #297736

wants to merge 2 commits into from

Conversation

petertrotman
Copy link
Contributor

Added package for diagon and myself as maintainer.

https://github.com/ArthurSonzogni/Diagon

Diagon is an interactive interpreter. It transforms markdown-style expression into an ascii-art representation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@applePrincess applePrincess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also split commits into two:

  • adding yourself into maintainer list
  • ading diagon package

pkgs/by-name/di/diagon/package.nix Outdated Show resolved Hide resolved
@applePrincess
Copy link
Contributor

Result of nixpkgs-review pr 297736 run on x86_64-linux 1

1 package built:
  • diagon

@petertrotman
Copy link
Contributor Author

Also split commits into two:

* adding yourself into maintainer list

* ading diagon package

Sure, done

@applePrincess
Copy link
Contributor

Could you rebase this repo so that ff6a2e4 is not part of this PR.
Merge e4f0ee3 and af76043 as a single commit diagon: init @ 1.1.158

@petertrotman
Copy link
Contributor Author

Could you rebase this repo so that ff6a2e4 is not part of this PR. Merge e4f0ee3 and af76043 as a single commit diagon: init @ 1.1.158

Done and done.

@applePrincess
Copy link
Contributor

Result of nixpkgs-review pr 297736 run on x86_64-linux 1

1 package built:
  • diagon

@petertrotman
Copy link
Contributor Author

Hi @applePrincess, I'm not sure what is supposed to happen with this. Would you please let me know what I need to do next to have this merged?

Thank you.

@applePrincess
Copy link
Contributor

Not really. I do not have rights to merge so I can not make it happen but you can mention this PR on Discourse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants