Switch the pkgs/by-name check to a separate repository
#297901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
check-by-name-separate-repo
branch
from
c5016c2
to
2174ec8
Compare
Closed
infinisil
force-pushed
the
check-by-name-separate-repo
branch
from
2174ec8
to
8cd90f9
Compare
infinisil
force-pushed
the
check-by-name-separate-repo
branch
from
8cd90f9
to
177fc1a
Compare
philiptaron
approved these changes
Mar 26, 2024
| @@ -108,13 +108,13 @@ There's some limitations as to which packages can be defined using this structur | |||
|
|
|||
| ## Validation | |||
|
|
|||
| CI performs [certain checks](../test/nixpkgs-check-by-name/README.md#validity-checks) on the `pkgs/by-name` structure. | |||
| This is done using the [`nixpkgs-check-by-name` tool](../test/nixpkgs-check-by-name). | |||
| CI performs [certain checks](https://github.com/NixOS/nixpkgs-check-by-name?tab=readme-ov-file#validity-checks) on the `pkgs/by-name` structure. | |||
There was a problem hiding this comment.
Future: we should publish with GitHub pages so that https://nixpkgs-check-by-name.github.io/ is the URL.
There was a problem hiding this comment.
Doesn't seem necessary, but yeah that's an option :)
|
Drafted because I noticed a minor problem that would occur with the follow-up removal PR, where I wanted to be able to remove |
The nixpkgs-check-by-name tooling is [being moved](NixOS#286559 (comment)) to a [separate repo](https://github.com/NixOS/nixpkgs-check-by-name). This commit updates Nixpkgs CI to use it instead of the tree inside Nixpkgs No changes have been made to the tooling locally since it was moved: - [Exported history](https://github.com/NixOS/nixpkgs/commits/55bf02190ee57fcf83490fd7b6bf7834e28c9c86/pkgs/test/nixpkgs-check-by-name) - [Imported history](https://github.com/NixOS/nixpkgs-check-by-name/commits/d579e1821d56c79fd90dab34b991cc7bdab7a5c6/)
infinisil
force-pushed
the
check-by-name-separate-repo
branch
from
177fc1a
to
f7ea336
Compare
|
Force pushed with the necessary changes (diff) |
1 task
infinisil
added a commit
that referenced
this pull request
Mar 26, 2024
It was not removed in #297901 so that CI for that PR itself would not fail since CI runs from the base branch.
infinisil
added a commit
that referenced
this pull request
Mar 26, 2024
Since #297901, the tool is fetched from https://github.com/NixOS/nixpkgs-check-by-name, so there's no need to keep it around in Nixpkgs anymore
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Apr 10, 2024
Was moved in NixOS#297901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This completes the move of the
pkgs/by-nametooling to the new https://github.com/NixOS/nixpkgs-check-by-name repository, see #286559 for motivation.Note
I'm leaving in both
pkgs/test/nixpkgs-check-by-nameto make it easier to review the removal in a separate PR, andpkgs/test/nixpkgs-check-by-name/scripts/pinned-tool.jsonbecause it's needed for CI of this PR to succeed.This work is sponsored by Antithesis ✨
Things done
./maintainers/scripts/check-by-name.sh masterAdd a 👍 reaction to pull requests you find important.