nixos/prometheus: abbility to add downstream exporters #298171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkg20001
force-pushed
the
downstream-exporter
branch
from
38393f8
to
b2a6008
Compare
mkg20001
force-pushed
the
downstream-exporter
branch
4 times, most recently
from
fa4e0bd
to
8b85385
Compare
mkg20001
force-pushed
the
downstream-exporter
branch
from
8b85385
to
aa09415
Compare
mkg20001
force-pushed
the
downstream-exporter
branch
from
aa09415
to
8deb9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds the abbility to add downstream exporters while profiting from upstream's exporter config generator
Documentation of the new method: https://github.com/mgit-at/nixpkgs/blob/downstream-exporter/nixos/modules/services/monitoring/prometheus/exporters.md#adding-a-downstream-exporter-module-services-prometheus-exporters-downstream-exporter
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.