Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Francis: init at 1.1.0 #298182

Merged
merged 2 commits into from Apr 9, 2024
Merged

Francis: init at 1.1.0 #298182

merged 2 commits into from Apr 9, 2024

Conversation

cimm
Copy link
Contributor

@cimm cimm commented Mar 22, 2024 •
edited

Description of changes

Francis is a KDE desktop application to help using the pomodoro technique.

Fixes #293967.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@cimm cimm mentioned this pull request Mar 22, 2024
Closed
@cimm cimm marked this pull request as ready for review March 22, 2024 22:04
@cimm cimm force-pushed the add-francis-package branch 2 times, most recently from d23866e to a214e4a Compare March 23, 2024 09:45
@cimm cimm requested a review from FRidh as a code owner March 23, 2024 09:45
@cimm
Copy link
Contributor Author

cimm commented Mar 28, 2024

I think this is ready to be merged, anything that needs to be changed?

@Aleksanaa Aleksanaa merged commit 4d3e4f4 into NixOS:master Apr 9, 2024
6 of 7 checks passed
@cimm cimm deleted the add-francis-package branch April 14, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Francis
2 participants
@cimm @Aleksanaa