Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkhash: init at 1.5 #298192

Merged
merged 1 commit into from Mar 27, 2024
Merged

gtkhash: init at 1.5 #298192

merged 1 commit into from Mar 27, 2024

Conversation

ByteSudoer
Copy link
Contributor

Description of changes

Description: A cross-platform desktop utility for computing message digests or checksums.
Homepage: https://github.com/gtkhash/gtkhash
Changelog: https://github.com/gtkhash/gtkhash/blob/master/ChangeLog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/by-name/gt/gtkhash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gt/gtkhash/package.nix Show resolved Hide resolved
pkgs/by-name/gt/gtkhash/package.nix Show resolved Hide resolved
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, LMTM (Looks Mergeable To Me)

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3686

pkgs/by-name/gt/gtkhash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gt/gtkhash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gt/gtkhash/package.nix Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit fa03b03 into NixOS:master Mar 27, 2024
22 of 23 checks passed
@Thatoo
Copy link

Thatoo commented Mar 29, 2024

Sorry to disturb but I'm curious to understand how it works.
Why https://hydra.nixos.org/build/254428676#tabs-summary is saying it has been cancelled by user?

@SuperSandro2000
Copy link
Member

That's probably to free up build capacity on hydra. Just wait a bit until https://hydra.nixos.org/build/254652962 is done

@Thatoo
Copy link

Thatoo commented Apr 4, 2024

@SuperSandro2000 could it be backported to 23.11?

@AndersonTorres
Copy link
Member

@SuperSandro2000 could it be backported to 23.11?

Feel free to cherry-pick it manually.

@Thatoo
Copy link

Thatoo commented Apr 7, 2024

What do you mean by "cherry-pick it manually" ?

@AndersonTorres
Copy link
Member

Backports in Nixpkgs are done by git cherry-pick commits from Master to Release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants