New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ndi: 5.6.0 -> 5.6.1 + update src and fix lib symlink #298259
Conversation
Current bin symlink problem:
|
Linking this issue too since its relevant #219578 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/exclude-package-from-cache-nixos-org/44178/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title should be updated to indicate the version change as well.
Updated, thanks @JohnRTitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to @pSub for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of changes
The NDI library is currently broken. Adding a couple lines to remove the old bin -> lib symlink and update it with the correct path.
#82617 Brought up the idea of just sourcing the file for the user. I am not entirely sure how to handle the acceptance of NewTek's EULA but figured I'd get this up so others might be able to help contribute on that front.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.