Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive.bin.core: patch ttfdump buffer overflow, CVE 2024-25262 #298721

Merged
merged 1 commit into from Mar 24, 2024

Conversation

xworld21
Copy link
Contributor

Description of changes

Some context at TeX-Live/texlive-source#63
The patch itself is one line.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@xworld21 xworld21 requested a review from veprbl March 24, 2024 20:11
@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Mar 24, 2024
@veprbl
Copy link
Member

veprbl commented Mar 24, 2024

@GrahamcOfBorg build tests.texlive

@veprbl veprbl merged commit 83a2696 into NixOS:master Mar 24, 2024
24 of 26 checks passed
@lolbinarycat
Copy link
Contributor

a few packages (eg. python3.11-biopython-1.83) seem to fail to build after this, unsure if they were already failing before.

@lolbinarycat
Copy link
Contributor

also, shouldn't this be backported?

Copy link
Contributor

Successfully created backport PR for release-23.11:

@xworld21
Copy link
Contributor Author

a few packages (eg. python3.11-biopython-1.83) seem to fail to build after this, unsure if they were already failing before.

Most likely already broken, that's quite usual with python packages.

also, shouldn't this be backported?

Probably yes! I think the ttfdump sources haven't changed in ages. If the patch applies cleanly, we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants