buildGoModule: warn about buildFlags only when using buildPhase provided by buildGoModule #298847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
force-pushed
the
build-go-module-buildflag
branch
from
c45a9e8
to
2c17e25
Compare
katexochen
approved these changes
Apr 18, 2024
Warn about buildFlags and ldflags only when using buildPhase provided by buildGoModule. This allows developers to use buildFlags in custom buildPhase.
…ation Avoid "global" warnings that complicates fixed-point arguments support.
ShamrockLee
force-pushed
the
build-go-module-buildflag
branch
from
2c17e25
to
8d861e6
Compare
|
Bump onto Add a commit that moves @katexochen Could you help me take a look again? |
wegank
approved these changes
Apr 18, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3842 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1608 |
kalbasit
approved these changes
May 3, 2024
kalbasit
added
12.approvals: 3+
12.approved-by: package-maintainer
and removed
12.approvals: 2
labels
|
This would have merge conflicts with #279391 on staging (fixed) |
|
Sorry @wegank , missed that. Let me know if you need an additional pair of eyes on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The warning that suggests using
ldflagsinstdead ofbuildFlagsorbuildFlagsArrayis relevant only whenbuildPhaseprovided bybuildGoModule. It becomes annoying if developers specifies a Make-based build phase and try to usebuildFlagsthere.This PR fixes this issue by attaching the warning to the
buildPhaseimplementation bybuildGoModule. If applied, the warning won't be triggered ifbuildPhaseis specified otherwise, during packaging or overriding.This PR also moves
GOFLAGS-related warnings where the attributeGOFLAGSis specified. This clears away the remaining "global" warnings, simplifying the work to fix overriding and adopt fixed-point arguments.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.