rpl: init at 1.5.6 #29894
Merged
rpl: init at 1.5.6 #29894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 28, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -19269,6 +19269,8 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| rpl = callPackage ../tools/text/rpl {}; | |||
There was a problem hiding this comment.
If it is not a python library, please move it to all-packages.nix instead.
There was a problem hiding this comment.
it's a python program but not a library ? still going to all-packages.nix ?
There was a problem hiding this comment.
Yes. We need to build python programs only against a single python version. pythonPackages are build against all versions.
vyp
reviewed
Sep 28, 2017
pkgs/tools/text/rpl/default.nix
Outdated
| src = fetchFromGitHub { | ||
| owner="kcoyner"; | ||
| repo="rpl"; | ||
| rev="v${version}"; |
There was a problem hiding this comment.
Really nitpicky so sorry, but spaces around = for these?
There was a problem hiding this comment.
I've aligned = with vim-lion, hopes that's not a problem xD
A python program that helps replacing string in files.
|
I pushed a new version with your comments adressed (hopefully). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A python program that helps replacing string in files.
Motivation for this change
One hell of a program, kinda like "fd". I find it very helpful to replace strings in multiple files. It's packaged in debian too.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)