gnomeExtensions.ddterm: fix gjs path and dependencies #298973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: GNOME
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
jtojnar
reviewed
Mar 25, 2024
tmyllymaki
force-pushed
the
update-ddterm
branch
3 times, most recently
from
b9c2fb1
to
0850395
Compare
This was referenced Apr 17, 2024
Artturin
reviewed
Apr 22, 2024
tmyllymaki
force-pushed
the
update-ddterm
branch
from
0850395
to
d79d5a8
Compare
wegank
reviewed
May 3, 2024
Comment on lines
50
to
51
| nativeBuildInputs = [ gjs gobject-introspection wrapGAppsHook ]; | ||
| buildInputs = [ vte libhandy ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ gjs gobject-introspection wrapGAppsHook ]; | |
| buildInputs = [ vte libhandy ]; | |
| nativeBuildInputs = [ gobject-introspection wrapGAppsHook ]; | |
| buildInputs = [ gjs vte libhandy ]; |
Imagine you're cross-compiling from x86_64-linux to aarch64-linux, you'll certainly want gjs to be native to aarch64-linux so that it runs on the host. So gjs should be in buildInputs.
|
As long as this PR is not merged #305991 is still open and an overlay would be necessary. How would that overlay look like on NixOS (without home-manager)? See my question here: #305991 (comment) |
The new version has #!@GJS_SHEBANG@ which ended up as #!/usr/bin/gjs -> #!/usr/bin//nix/store../bin/gjs. gnomeExtensions.ddterm: add libhandy as dependency libhandy was added as dependency on commit: ddterm/gnome-shell-extension-ddterm@eade14f
|
When will this fix be available for NixOS 24.05 ?? |
|
Successfully created backport PR for |
1 task
Wow this was quick, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version has
#!@GJS_SHEBANG@which ended up as#!/usr/bin/gjs->#!/usr/bin//nix/store../bin/gjs. This change changes the whole line before building.Also added
libhandyas dependency which is added in commit ddterm/gnome-shell-extension-ddterm@eade14f.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.