Avoid top-level with ...; in pkgs/development/coq-modules
#299010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analysis/default.nix
fricklerhandwerk
approved these changes
Mar 25, 2024
6 tasks
|
Please change the manual first. |
I did three weeks ago. 9f8a580 |
|
Here we go: #299927 |
This was merged; what would you like to do next? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Using
withat a top-level scope is an anti-pattern. The tracking issue is #208242. This is a pure refactor: there is no functional change contained in this PR.I used the refactor strategy that looks for the uses of names coming from
lib,pkgs,python3Packages, and more.Following advice, I also preferred to inherit names from
libinstead ofbuiltinswhere there was a choice. I also preferred to inherit fromlibin one place, rather than to have a mixture oflib.thingandinherit (lib) thing.There are no rebuilds when I run
nixpkgs-review rev HEAD, so I've targeted master with this PR.Things done
nixpkgs-review rev HEAD.