Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerospace: init at 0.9.0-beta #299099

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

t-monaghan
Copy link

@t-monaghan t-monaghan commented Mar 26, 2024

Description of changes

Introduces aerospace - an i3 like tiling window manager for macOS. I opted to pull from built binaries as the build process is a complex one with some swift dependencies that I couldn't work through after a full days effort. Please let me know if there are any issues with this approach.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@t-monaghan t-monaghan force-pushed the add-aerospace branch 4 times, most recently from dac8738 to 83deb8c Compare March 27, 2024 22:59
Copy link
Contributor

@lolbinarycat lolbinarycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting is a bit unusual, although i can't think of any official guidelines that are being broken for most of it.

pkgs/by-name/ae/aerospace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ae/aerospace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ae/aerospace/package.nix Show resolved Hide resolved
@nikitabobko
Copy link

I opted to pull from built binaries as the build process is a complex one with some swift dependencies that I couldn't work through after a full days effort

Feel free to describe problems you faced in a new issue https://github.com/nikitabobko/AeroSpace/issues/new The process of building shouldn't be complex. GH actions builds AeroSpace without any problems https://github.com/nikitabobko/AeroSpace/actions/runs/8502224571

But besides the issues with the build setup, building the binary in nix has other flaws. I sign the binary with my private key which is needed to retain macOS accessibility permission across updates (unsigned binaries will re-request the accessibility permission on every update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants