treewide: fix various metadata urls #299293
Conversation
lolbinarycat
force-pushed
the
meta-url-fix
branch
from
5ead403
to
915b968
Compare
There was a problem hiding this comment.
Please make sure your commits and messages match up with the contributing guidelines, especially in terms of squashing commits and naming them. "Merge branch 'master' into meta-url-fix" shouldn't be contributed like that. You probably want to rebase and force push to your fork to fix it.
Other than that, two inconsistencies i found are explained in the review comments.
| @@ -40,7 +43,7 @@ python3.pkgs.buildPythonApplication rec { | |||
| description = "AWS post-exploitation tool"; | |||
| mainProgram = "ec2stepshell"; | |||
| homepage = "https://github.com/saw-your-packet/EC2StepShell"; | |||
| changelog = "https://github.com/saw-your-packet/EC2StepShell/blob/${version}/CHANGELOG.txt"; | |||
| changelog = "https://github.com/saw-your-packet/EC2StepShell/blob/${rev}/CHANGELOG.txt"; | |||
There was a problem hiding this comment.
if you put src.rev here instead of referring to the constant, you don't need to define the constant containing the git commit hash.
| @@ -35,6 +35,6 @@ stdenv.mkDerivation rec { | |||
| ]; | |||
| platforms = platforms.linux; | |||
| license = licenses.zlib; | |||
| downloadPage = "http://matricks.github.com/bam/"; | |||
| downloadPage = "http://matricks.github.io/bam/"; | |||
my local nixpkgs copy is maintained using shallow pulls, and the rebase command has several modes it can operate in. if you can point me towards the correct incantations that will make sure i don't have to open a new PR, that would be greatly appreciated. also, the thing about merges should probably be in the contributing guide. |
|
To fix your previous commit, If you already made a new one (like this merge commit here), you might want to use Be aware all of these require force pushes and therefore are only advised to be used on forks you own and use for PRs. Never force push to production repos. |
|
trying to rebase gives me hundreds of merge conflicts. |
Description of changes
i found a bunch of broken metadata urls, this fixes some of them.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.