nixos/console: Fix systemd-vconsole-setup

[pinpox]

Description of changes

Fixes the problem described in #257904

Fixes #257904

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lelgenio]

The current implementation does not solve the issue. The same error still occurs.

[PedroHLC]

Works for me, diff LGTM.

Tested by adding the following to my config:

{pkgs, config, ...}:

{
  console.font = "Lat2-Terminus16";
  boot.initrd.systemd.contents."/etc/kbd/consolefonts" =
    let
      cfg = config.console;
      consoleEnv = kbd: pkgs.buildEnv {
        name = "console-env";
        paths = [ kbd ] ++ cfg.packages;
        pathsToLink = [
          "/share/consolefonts"
          "/share/consoletrans"
          "/share/keymaps"
          "/share/unimaps"
        ];
      };
    in
    lib.mkIf (!cfg.earlySetup && cfg.font != null) { source = "${consoleEnv config.boot.initrd.systemd.package.kbd}/share/consolefonts"; };
}

[lelgenio]

Working fine! 😃 👍

Maybe consider squashing and prefix the commit message with "nixos/console:"

[PedroHLC]

About the commit number and message/name/title that lelgenio commented:

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

[pinpox]

About the commit number and message/name/title that lelgenio commented:

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

Sorry, had missed that message. Should be fixed now!

[rnhmjoj]

Isn't this essentially undoing 18363ca? It seems to me that now you're always setting the console with systemd initrd.

[pinpox]

Isn't this essentially undoing 18363ca? It seems to me that now you're always setting the console with systemd initrd.

I still really want to fix this, as it's causing me trouble but don't know how to proceed. Can someone more familiar with these modules give some pointers on how to resolve this?

[rnhmjoj]

@dasJ ?