Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giac, xcas: init at 1.4.9 #29947

Merged
merged 3 commits into from Sep 30, 2017
Merged

giac, xcas: init at 1.4.9 #29947

merged 3 commits into from Sep 30, 2017

Conversation

symphorien
Copy link
Member

Motivation for this change

package xcas on NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • NA Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

## xcas is buildable on darwin but there are specific instructions I could
## not test
platforms = platforms.linux;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add maintainers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@orivej orivej self-assigned this Sep 30, 2017
@orivej
Copy link
Contributor

orivej commented Sep 30, 2017

@symphorien Please review my changes in 0e725f43066921b2e4d5366c12c14576289086e8
I've noticed that hevea is not used during the build (the package must be installing pregenerated documentation), I'll delete it before the merge if it will remain unused.

@symphorien
Copy link
Member Author

no problems for the changes you proposed.
How did you spot that hevea was not needed ? I put much efforts (given the build time) to strip unneeded dependencies from those listed on the home page, but I didn't spot it.

@orivej
Copy link
Contributor

orivej commented Sep 30, 2017

I used fptrace -d deps.json nix-build '<nixpkgs>' -A giac-with-xcas and then <deps.json jq . | grep hevea | sort -u. (NB. Apparently fptrace only works when nix sandboxing is disabled.)
This also let me know that yacc was unused (after all, bison is its replacement), perl did not run during the build (and so was not needed in nativeBuildInputs), and gfortran was only used as a library.

@symphorien
Copy link
Member Author

Ah I did the same. I may have misread the output :°
To work around sandboxing I use nix-shell --pure --run "genericBuild" in a temp dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants