Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir-ls: fix building with elixir_1_16 #299515

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

adamcstephens
Copy link
Contributor

Description of changes

Fixes error when building with elixir 1.16

error: builder for '/nix/store/4bk3i1cyf6a6dxm9j31j9z4wf860iw3r-elixir-ls-0.20.0.drv' failed with exit code 1;
       last 10 log lines:
       >
       > ** (UndefinedFunctionError) function Mix.Dep.load_on_environment/1 is undefined or private

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@happysalada
Copy link
Contributor

Oh wow thats amazing, this is the last thing before the global elixir switch can be set to 1.16

Ill try to test that soon

@happysalada happysalada merged commit cabdd9c into NixOS:master Mar 27, 2024
23 of 24 checks passed
@adamcstephens adamcstephens deleted the elixir-ls/0.20 branch March 27, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants