Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

redict: init at 7.3.0 #300049

Merged
merged 1 commit into from Apr 9, 2024
Merged

redict: init at 7.3.0 #300049

merged 1 commit into from Apr 9, 2024

Conversation

yu-re-ka
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@gmemstr gmemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit delayed, because apparently the tests don't run properly on the Linux Zen kernel? Either way...

Result of nixpkgs-review pr 300049 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
1 package built:
  • redict

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Mar 30, 2024

I would like to hear from the redis maintainers about the proposed migration path: @berdario @globin @marsam

@theoparis
Copy link
Contributor

Redict 7.3.0 is now stable - should I create a new PR or do you plan on updating this PR?

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Apr 9, 2024

I'll update this PR, but there are still open questions on how to integrate redict properly with the nixos modules

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Apr 9, 2024

Bumped to 7.3.0 and also removed the module related changes for now, so that we can merge this soon

@yu-re-ka yu-re-ka changed the title redict: init at 7.3.0-rc2 redict: init at 7.3.0 Apr 9, 2024
Copy link
Member

@gmemstr gmemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 300049 run on x86_64-linux 1

1 package built:
  • redict

@ofborg ofborg bot requested a review from gmemstr April 9, 2024 10:02
@yu-re-ka yu-re-ka merged commit 517c226 into NixOS:master Apr 9, 2024
26 of 27 checks passed
@yu-re-ka yu-re-ka deleted the redict branch April 9, 2024 10:59
@trofi
Copy link
Contributor

trofi commented Apr 21, 2024

There is no nixosTests.redict:

$ nix build --no-link -f. redict.tests.redict
error: attribute 'redict' missing
       at pkgs/by-name/re/redict/package.nix:83:27:
           82|
           83|   passthru.tests.redict = nixosTests.redict;
             |                           ^
           84|
       Did you mean redis?

Should the test be dropped? Or maybe redis one should be adapted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants