Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.RQuantLib: Fix quantlib #300087

Merged
merged 2 commits into from
Apr 8, 2024
Merged

rPackages.RQuantLib: Fix quantlib #300087

merged 2 commits into from
Apr 8, 2024

Conversation

Kupac
Copy link
Contributor

@Kupac Kupac commented Mar 29, 2024

Description of changes

  • Update quantlib
  • Enable intraday (=high resolution) dates
  • Fix rPackages.RQuantLib

Re-opening PR agains r-updates. Original: #292029

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Kupac Kupac requested a review from jbedo as a code owner March 29, 2024 21:18
@Kupac Kupac changed the title Fix quantlib rPackages.RQuantLib: Fix quantlib Mar 29, 2024
jbedo
jbedo requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@jbedo jbedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this bumps something outside of the package tree, I'd rather merge it in master then r-updates. I notice it doesn't have any maintainers though: would you like to maintain this package?

pkgs/development/libraries/quantlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/quantlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/r-modules/default.nix Outdated Show resolved Hide resolved
@Kupac
Copy link
Contributor Author

Kupac commented Mar 29, 2024

I'll just fix the original PR against master, then. I can be maintainer if it's needed.

@Kupac Kupac marked this pull request as draft March 29, 2024 22:20
@Kupac Kupac changed the base branch from r-updates to master March 29, 2024 22:39
@Kupac Kupac force-pushed the fix_quantlib branch 3 times, most recently from c926059 to c69dff1 Compare March 29, 2024 22:50
@Kupac Kupac marked this pull request as ready for review March 29, 2024 23:21
@Kupac Kupac requested a review from jbedo March 29, 2024 23:21
Kupac and others added 2 commits March 30, 2024 23:31
@Kupac
quantlib: 1.29 -> 1.33
98280b5 
Upgrade library and enable intraday (=high resolution) dates

Unorphan library

Indent better

cmakeflags!
@Kupac @jbedo
rPackages.RQuantLib: fix build error
4896b1d 
Upgrade library

Co-authored-by: Justin Bed艖 <cu@cua0.org>
@jbedo jbedo merged commit beb6277 into NixOS:master Apr 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedo jbedo jbedo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kupac @jbedo @wegank