androidenv: fix NDK toolchains #300386
Closed
androidenv: fix NDK toolchains #300386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3725 |
numinit
approved these changes
Mar 31, 2024
|
LGTM. FYI #300407 |
mukilan
reviewed
Mar 31, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3769 |
|
I'm a nix newbe on NixOS, trying to get Tauri in the android emulator to work. Before this PR: After this PR - I'm not getting this error anymore :) |
Philipp-M
reviewed
May 20, 2024
13 tasks
Co-authored-by: Philipp Mildenberger <philipp@mildenberger.me>
|
Its alternative PR got merged, so I assume the problem is fixed and we don't need this one. |
wattmto-nixpkgs-automation bot
pushed a commit
to wattmto/nixpkgs
that referenced
this pull request
Jun 1, 2024
Fixes NixOS#298285, alternative to NixOS#300386. As suggested in NixOS#298285 `lib64` was renamed to `lib`, so just doing the same as for `lib64` seems to fix the issue. See also recent discussion in NixOS#300386.
florian-sanders-cc
pushed a commit
to florian-sanders-cc/nixpkgs
that referenced
this pull request
Jun 6, 2024
Fixes NixOS#298285, alternative to NixOS#300386. As suggested in NixOS#298285 `lib64` was renamed to `lib`, so just doing the same as for `lib64` seems to fix the issue. See also recent discussion in NixOS#300386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes #298285. Wrab executables in toolchains.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.