dhcpig: init at 1.6 #300555
Merged
dhcpig: init at 1.6 #300555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imadnyc
suggested changes
Mar 31, 2024
|
Sick! I think the only things that I would change now are the quotes around the PR name and removing the stuff in the commit body that you got from squashing. |
CyberShadow
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Commit message still needs cleanup.
fabaff
reviewed
Apr 1, 2024
|
Related to #81418 |
fabaff
reviewed
Apr 1, 2024
Aleksanaa
approved these changes
Apr 3, 2024
Aleksanaa
reviewed
Apr 3, 2024
pkgs/by-name/dh/dhcpig/package.nix
Outdated
| ]; | ||
|
|
||
| installPhase = '' | ||
| instal -Dm755 pig.py $out/bin/dhcpig |
There was a problem hiding this comment.
Suggested change
| instal -Dm755 pig.py $out/bin/dhcpig | |
| install -Dm755 pig.py $out/bin/dhcpig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.