ffmpeg: add amf support

[jopejoe1]

Description of changes

I tested that this builds, but I do not have a machine with an AMD GPU to test this on.

Edit: now that i include the amf driver in this pr ot would fix #204502

Closes #204502

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[justinas]

I am able to compile, but:

[h264_amf @ 0x1a7b440] DLL libamfrt64.so.1 failed to open

I think AMF requires AMDGPU-PRO driver, which is not super usable on NixOS (requires an older kernel and whatnot). 😕

nixpkgs/nixos/modules/hardware/video/amdgpu-pro.nix

Lines 32 to 38 in 127c068

	boot.kernelPackages = pkgs.linuxKernel.packagesFor
	(pkgs.linuxKernel.kernels.linux_5_10.override {
	structuredExtraConfig = {
	DEVICE_PRIVATE = kernel.yes;
	KALLSYMS_ALL = kernel.yes;
	};
	});

[jopejoe1]

I think AMF requires AMDGPU-PRO driver, which is not super usable on NixOS (requires an older kernel and whatnot). 😕

According to the release notes of amf there is experimental support for RADV and full support for pro drivers.

https://github.com/GPUOpen-LibrariesAndSDKs/AMF/releases/tag/v1.4.33

[justinas]

According to the release notes of amf there is experimental support for RADV and full support for pro drivers.

https://github.com/GPUOpen-LibrariesAndSDKs/AMF/releases/tag/v1.4.33

That's cool! However, we still need libamfrt64.so from the AMDGPU-PRO release. On traditional distros, it would get installed via

sudo amdgpu-install -y --usecase=amf
https://github.com/GPUOpen-LibrariesAndSDKs/AMF/wiki/Driver%20Linux

I attempted to hack this together (use the lib from AMDGPU-PRO, but not the driver itself) on my 23.11 machine via:

{
  hardware.opengl = {
    driSupport32Bit = true; # Steam, etc.
    enable = true;

    extraPackages = with pkgs; [
      rocmPackages.clr
      rocmPackages.clr.icd

      # added this
      (pkgs.runCommandNoCC "libamfrt" { } ''
        mkdir -p $out/lib
        cp ${config.boot.kernelPackages.amdgpu-pro}/opt/amdgpu-pro/lib/libamfrt* $out/lib
        ln -s $out/lib/libamfrt64.so{,.1}
      '')
    ];
  };
}

but no luck:

$ ./ffmpeg-amf/bin/ffmpeg -hide_banner -loglevel warning -i ~/Downloads/bigbuck_bunny_8bit_15000kbps_1080p_60.0fps_h264.mp4 -c:v h264_amf out.mp4
zsh: segmentation fault (core dumped)

Per GPUOpen-LibrariesAndSDKs/AMF#457 , this might need more shared libraries, a newer Mesa, etc... 😮‍💨

[Atemu]

This clearly needs some work.

[jopejoe1]

Found out that the min version of amdgpu-pro required is 24.1.1 (23.40.02) but the version we packaged is only at 21.30.

[Svenum]

If a new amdgpu-pro version with newer kernel is on unstable I could try things in this PR.

[Atemu]

@Svenum could you also publish that as a draft PR? That way others can pick it up in case you hit a wall you're not able to penetrate.

[Svenum]

I am sorry if I have expressed myself incomprehensibly, but i was not able to achive an amdgpu-pro installation on a newer kernel, but I will try.

[Atemu]

Ah, sorry for the confusion.

[jopejoe1]

got this to work now can be tested by adding amf-amdgpu-pro to hardware.graphics.extraPackages on nixos and then running ffmpeg -i test.mp4 -c:v hevc_amf out.mp4

[jopejoe1]

Removed the -amdgpu-pro part of the package name, as the package also works with the open-source driver.

[Atemu]

Generally LGTM but untested.

A few questions.

[Atemu]

Removed the -amdgpu-pro part of the package name, as the package also works with the open-source driver.

What exactly do you mean by that? amdenc is evidently a closed-source driver.

[jopejoe1]

Removed the -amdgpu-pro part of the package name, as the package also works with the open-source driver.

What exactly do you mean by that? amdenc is evidently a closed-source driver.

That it also works together with the open-source AMD driver and not just the closed source one.

And i don't want to give the impression that it can only be used together with the closed source driver.

[Atemu]

That it also works together with the open-source AMD driver and not just the closed source one.

What kind of driver are we talking about here? DRM/DRI or OGL/VK?

[jopejoe1]

That it also works together with the open-source AMD driver and not just the closed source one.

What kind of driver are we talking about here? DRM/DRI or OGL/VK?

I was talking about the VK driver and that it can be mesa's radv instead of just using the one included in amdgpu-pro.

[Atemu]

Successfully produced a decodable HEVC video using:

LD_LIBRARY_PATH=$(nix-build -A amf)/lib/ $(nix-build -A ffmpeg-full)/bin/ffmpeg -f lavfi -i testsrc -t 10 -c:v hevc_amf -y /tmp/foo.mkv

(I presume you'd place amf in the system-wide driver path in an actual deployment.)

[jopejoe1]

(I presume you'd place amf in the system-wide driver path in an actual deployment.)

At least thats what i did while testing.