Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nekoray: init at 3.26 #300794

Merged
merged 2 commits into from Apr 10, 2024
Merged

nekoray: init at 3.26 #300794

merged 2 commits into from Apr 10, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Apr 1, 2024

Description of changes

Closes #244451

I successfully built the nekoray package, and using 2 extra derivations with buildGoModule, I added the required *_core files as well.

The fetching is a bit weird, because I didn't want to deal with upstream's WEIRD way of fetching other repositories.

This needs some testing as I haven't got any experience with this program.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Apr 2, 2024

Updated the PR to include the geodata files too.

@jys1670
Copy link

jys1670 commented Apr 2, 2024

Result of nixpkgs-review pr 300794 run on x86_64-linux 1

1 package built:
  • nekoray

Tested vless-xtls-reality, works as expected. The same applies to geosite.db (didn't try other .db files, but they should be fine too).
The only broken thing I found is "Scan QR Code", sadly it crashes with exception:

terminate called after throwing an instance of 'std::invalid_argument'
  what():  Invalid image format

Earlier I was using a patched nekoray binary as a workaround, it has similar problem now, but used to work before (around December 2023). Looks like some dependencies were updated, causing incompatibilities. But it is a minor feature, nothing critical.

Thank you for packaging this one!

@Aleksanaa Aleksanaa self-requested a review April 2, 2024 16:14
pkgs/by-name/ne/nekoray/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ne/nekoray/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ne/nekoray/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ne/nekoray/package.nix Outdated Show resolved Hide resolved
@Aleksanaa
Copy link
Member

Thanks for your contribution, I'll test it tomorrow. Also perhaps we need some capability wrappers or services for this, which can be done in another PR.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Apr 8, 2024

Would anyone here like to co-maintain this package? I'm not actually someone who uses this program, I just like packaging stuff, so I don't really know how to use the program.

Because of this I'm probably not qualified to create a service for this ATM.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested basic functionality. Looks good.

@Aleksanaa
Copy link
Member

@TomaSajt I will maintain the functionality of this package in the future. I will add myself to the maintainer in the next update.

@Aleksanaa
Copy link
Member

@ofborg eval

@Aleksanaa
Copy link
Member

@ofborg build

@Aleksanaa Aleksanaa merged commit b95f829 into NixOS:master Apr 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: nekoray
5 participants