nixos/monado: install monado-vulkan-layers #301044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
force-pushed
the
nixos/monado/vulkan-layers
branch
2 times, most recently
from
03af165
to
d370cda
Compare
|
Theoretically at least. I have no way to test it right now. |
Scrumplex
force-pushed
the
nixos/monado/vulkan-layers
branch
from
d370cda
to
9f12b15
Compare
Can confirm that it does work :) |
Pandapip1
approved these changes
Jun 22, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1771 |
Scrumplex
force-pushed
the
nixos/monado/vulkan-layers
branch
from
9f12b15
to
1febf79
Compare
Pandapip1
approved these changes
Jun 30, 2024
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> Co-authored-by: PassiveLemon <lemonl3mn@protonmail.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
nixos/monado/vulkan-layers
branch
from
1febf79
to
9954905
Compare
Pandapip1
reviewed
Jul 1, 2024
| rev = "ae43cdcbd25c56e3481bbc8a0ce2bfcebba9f7c2"; | ||
| sha256 = "sha256-QabYVKcenW+LQ+QSjUoQOLOQAVHdjE0YXd+1WsdzNPc="; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Nit: might be worth setting
Suggested change
| strictDeps = true; | |
Pandapip1
reviewed
Jul 3, 2024
Comment on lines
+18
to
+20
| layersPackage = mkPackageOption pkgs "monado-vulkan-layers" {}; | ||
|
|
||
| hardwarePackage = mkPackageOption pkgs "xr-hardware" {}; |
There was a problem hiding this comment.
Should we allow users to set null to disable either of these?
There was a problem hiding this comment.
I don't really think there is much of a point to this. If someone really wants to "debloat" their systems, they could set these to an empty derivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Derivation by @PassiveLemon
This should allow Monado to work on NVIDIA systems
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.