Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

davis: 4.4.1 -> 4.4.2 #301274

Merged
merged 2 commits into from
Apr 3, 2024
Merged

davis: 4.4.1 -> 4.4.2 #301274

merged 2 commits into from
Apr 3, 2024

Conversation

Ramblurr
Copy link
Contributor

@Ramblurr Ramblurr commented Apr 3, 2024

Description of changes

Release notes: https://github.com/tchapi/davis/releases/tag/v4.4.2

davis package:

nixos/davis module:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Release notes: https://github.com/tchapi/davis/releases/tag/v4.4.2

Removed composer.lock from nixpkgs tree because upstream contains it.
* Our patchset is no longer required (see tchapi/davis#156)
* Though the upstream var names changed, so we had to update those too
* These vars are managed by the nixos module and hence are not breaking
  changes for users of the module.
* Also removed need to specify postgres charset in non-standard way
  (see tchapi/davis#153)

Release notes: https://github.com/tchapi/davis/releases/tag/v4.4.2
@NixOS NixOS deleted a comment from Ramblurr Apr 3, 2024
@superherointj superherointj merged commit e008457 into NixOS:master Apr 3, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants