devcontainer: init at 0.58.0 #301313
Merged
devcontainer: init at 0.58.0 #301313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3742 |
Rucadi
changed the title
Rucadi
changed the title
|
@WolfangAukang I saw that you reviewed PR #276208 , could it be possible if you have time to review this one? |
Rucadi
force-pushed
the
devcontainer
branch
5 times, most recently
from
7c43a8e
to
5a71c98
Compare
|
I had to move from mkYarnPackage -> stdenv.mkDerivation, it simplifies the derivation and doesn't make ofborg checks fail. |
Rucadi
force-pushed
the
devcontainer
branch
2 times, most recently
from
9fa7732
to
c39c53e
Compare
|
Result of 1 package failed to build:
|
This is totally unexpected since I can build the derivation myself, will try the nixpkgs review. Thanks a lot for the review! |
|
Result of 1 package built:
|
@WolfangAukang It seems that it is working fine for me... should I add nodejs to the nativeBuildInputs list or not? |
After seeing some examples on Nixpkgs, it doesn't look like it is necessary |
|
@WolfangAukang could you approve the PR if it is ok for you? |
|
Result of 1 package built:
|
|
@Rucadi are you able to use ❯ git clone https://github.com/microsoft/vscode-remote-try-rust
❯ /home/bbigras/.cache/nixpkgs-review/pr-301313/results/devcontainer/bin/devcontainer up --workspace-folder ./vscode-remote-try-rust
[1 ms] @devcontainers/cli 0.58.0. Node.js v20.11.1. linux 6.8.4 x64.
Error: ENOENT: no such file or directory, open '/nix/store/vbpyr6xdfrzsirsj2745d0z21yyva2kl-devcontainer-0.58.0/libexec/scripts/updateUID.Dockerfile'
{"outcome":"error","message":"ENOENT: no such file or directory, open '/nix/store/vbpyr6xdfrzsirsj2745d0z21yyva2kl-devcontainer-0.58.0/libexec/scripts/updateUID.Dockerfile'","description":"An error occurred setting up the container."} |
|
Let me take a look, We are using this derivation at work successfully. |
|
@bbigras can you try this version. If this works, maybe you can help me fix the checks issues. |
|
That's the issue I don't really know how to solve with this version because this seems to come from yarn2nix :\ Another thing we could try is to put the package as a nodePackage here? pkgs/development/node-packages I have not tested it. Maybe we can fix the version of the first commit to just have the scripts in the correct place? |
|
@bbigras Copying the scripts folder to libexec worked, got go container running, can you test it? |
|
Result of 1 package built:
|
👍 |
bbigras
approved these changes
Apr 11, 2024
sikmir
approved these changes
Apr 12, 2024
|
Result of 1 package built:
|
This was referenced Apr 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Devcontainer (https://containers.dev/) is an opensource MIT implementation of the devcontainer specs.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.