asahi-*: init #302205
Merged
asahi-*: init #302205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
flokli
requested changes
Apr 7, 2024
There was a problem hiding this comment.
These packages need metadata (see https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes), and should ideally be one commit per package addition following the commit subject scheme from CONTRIBUTING.md. Can you update it?
lukaslihotzki
force-pushed
the
asahi-nvram
branch
from
2a7225a
to
f5394fb
Compare
flokli
reviewed
Apr 8, 2024
lukaslihotzki
force-pushed
the
asahi-nvram
branch
from
f5394fb
to
22865a3
Compare
flokli
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a set of binaries to interact with the NVRAM on Apple Silicon machines, which are also packaged by the Fedora Asahi Remix. In tpwrules/nixos-apple-silicon#179 it was recommended to add these to the main nixpkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.