Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

insync-nautilus: init at 3.8.7.50516 #302422

Merged
merged 2 commits into from Apr 12, 2024
Merged

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Apr 7, 2024

Description of changes

insync-nautilus: initial package

This package allows nautilus file manager to show insync emblems of syncing status:

image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@hellwolf
Copy link
Contributor Author

hellwolf commented Apr 7, 2024

@ofborg build insync insync-nautilus

again.

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust PR and commit title to the conventions

pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Show resolved Hide resolved
pkgs/by-name/in/insync/package.nix Outdated Show resolved Hide resolved
@hellwolf
Copy link
Contributor Author

hellwolf commented Apr 8, 2024

Please adjust PR and commit title to the conventions

No problem.

Just to be clear, is it about the "insync-nautilus: init at x.y.z" ?

@msanft
Copy link
Contributor

msanft commented Apr 8, 2024

Just to be clear, is it about the "insync-nautilus: init at x.y.z" ?

Exactly, both PR and commit title should be insync-nautilus: init at 3.8.7.50516. Thanks a lot!

@hellwolf hellwolf changed the title New package: insync nautilus insync-nautilus: init at 3.8.7.50516 Apr 8, 2024
@hellwolf hellwolf force-pushed the insync-nautilus branch 2 times, most recently from f972483 to dde1f08 Compare April 8, 2024 19:19
@hellwolf
Copy link
Contributor Author

hellwolf commented Apr 8, 2024

Just to be clear, is it about the "insync-nautilus: init at x.y.z" ?

Exactly, both PR and commit title should be insync-nautilus: init at 3.8.7.50516. Thanks a lot!

done

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3767

pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Show resolved Hide resolved
pkgs/by-name/in/insync/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync-nautilus/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/in/insync/package.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1584

- insync-emblem-icons is included, which is used by other insync
  pakcages.
@hellwolf hellwolf requested a review from drupol April 9, 2024 19:32
@wegank wegank requested review from drupol and removed request for drupol April 11, 2024 12:12
@drupol drupol merged commit aca35f8 into NixOS:master Apr 12, 2024
23 of 24 checks passed
@hellwolf hellwolf deleted the insync-nautilus branch April 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants