Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcl-cli: init at 0.8.5 #302488

Merged
merged 2 commits into from
Apr 10, 2024
Merged

kcl-cli: init at 0.8.5 #302488

merged 2 commits into from
Apr 10, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 8, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/kc/kcl/package.nix Outdated Show resolved Hide resolved
@Peefy Peefy mentioned this pull request Apr 8, 2024
13 tasks
pkgs/by-name/kc/kcl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/kc/kcl/package.nix Outdated Show resolved Hide resolved
@Peefy Peefy force-pushed the patch-5 branch 2 times, most recently from 25fd393 to e128119 Compare April 8, 2024 09:00
@Peefy Peefy force-pushed the patch-5 branch 2 times, most recently from c28ff1f to 3bb2cf1 Compare April 8, 2024 09:57
@msanft
Copy link
Contributor

msanft commented Apr 8, 2024

@ofborg eval

@msanft msanft self-requested a review April 8, 2024 11:06
@msanft
Copy link
Contributor

msanft commented Apr 8, 2024

I'm not entirely sure why ofborg-eval-lib-tests fails. But judging from the log, it doesn't seem to be related to the contents of this PR.

@Peefy
Copy link
Contributor Author

Peefy commented Apr 8, 2024

I'm not entirely sure why ofborg-eval-lib-tests fails. But judging from the log, it doesn't seem to be related to the contents of this PR.

Thank you! Can we retry it ofborg-eval-lib-tests? Perhaps it was an occasional mistake? 🤔

@msanft
Copy link
Contributor

msanft commented Apr 8, 2024

I don't think one can manually trigger this check.

You might want to git fetch origin master:master, git rebase origin/master and then git push --force-with-lease to trigger a re-run of all CI.

Signed-off-by: peefy <xpf6677@163.com>
@Aleksanaa
Copy link
Member

@ofborg eval

@Peefy
Copy link
Contributor Author

Peefy commented Apr 8, 2024

I don't think one can manually trigger this check.

You might want to git fetch origin master:master, git rebase origin/master and then git push --force-with-lease to trigger a re-run of all CI.

Thank you! I trigger the CI and it is still failed.

@Peefy
Copy link
Contributor Author

Peefy commented Apr 9, 2024

Sorry, does anyone have more suggestions? It seems like the block is here.

@Peefy
Copy link
Contributor Author

Peefy commented Apr 9, 2024

@ofborg eval

@Aleksanaa
Copy link
Member

@ofborg build

@Peefy
Copy link
Contributor Author

Peefy commented Apr 9, 2024

@ofborg build

@Aleksanaa Thank you! ❤️

@Aleksanaa
Copy link
Member

Don't thank me, it doesn't work and I don't know why...

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, 1 more change:

PR and commit title now need to be kcl-cli: ....

Then this is good to merge imo.

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy changed the title kcl: init at 0.8.5 kcl-cli: init at 0.8.5 Apr 9, 2024
@Peefy
Copy link
Contributor Author

Peefy commented Apr 9, 2024

Sorry, 1 more change:

PR and commit title now need to be kcl-cli: ....

Then this is good to merge imo.

Thank you! Fixed.

@msanft msanft mentioned this pull request Apr 9, 2024
13 tasks
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Peefy
Copy link
Contributor Author

Peefy commented Apr 10, 2024

I have noticed that all the CI has been approved. Will it merge with the near future?

@Aleksanaa Aleksanaa merged commit 1be4588 into NixOS:master Apr 10, 2024
27 of 28 checks passed
@Peefy Peefy deleted the patch-5 branch April 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants