Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anchor: init at 0.29.0 #302585

Merged
merged 1 commit into from Apr 10, 2024
Merged

anchor: init at 0.29.0 #302585

merged 1 commit into from Apr 10, 2024

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 8, 2024

Description of changes

anchor: init at 0.29.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@xrelkd xrelkd force-pushed the add/anchor branch 3 times, most recently from 1caa2b2 to 05ff89b Compare April 9, 2024 07:23
Aleksanaa
Aleksanaa approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm, didn't test functionality

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 10, 2024

Hi @Aleksanaa @wegank,
Thanks for the review, please help me merge this PR. Thank you so much.

@wegank
Copy link
Member

wegank commented Apr 10, 2024

Result of nixpkgs-review pr 302585 run on aarch64-darwin 1

1 package built:
  • anchor

@wegank wegank merged commit 4cdaf50 into NixOS:master Apr 10, 2024
24 checks passed
@xrelkd xrelkd deleted the add/anchor branch April 10, 2024 10:01
@sg-qwt
Copy link
Contributor

sg-qwt commented Apr 26, 2024

@xrelkd
Do you have any example devshell on how to make anchor work? I presume this requires #304009 for cargo-build-sbf?

But even with #304009 applied, nix-shell -p anchor solana-validator

When I tried to run anchor build on some hello-world repo, I can see it's trying to
⠤ 🚚 Downloading https://github.com/solana-labs/platform-tools/releases/download
Then failed with
[2024-04-26T19:02:55.287817230Z ERROR cargo_build_sbf] Failed to install platform-tools: Read-only file system (os error 30)

Am I missing something here?

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @wegank @sg-qwt @Aleksanaa