Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayfarer: init at 1.2.4 #302772

Merged
merged 1 commit into from Apr 13, 2024
Merged

wayfarer: init at 1.2.4 #302772

merged 1 commit into from Apr 13, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Apr 9, 2024

Description of changes

Doesn't work for me on sway (similar failure as kooha), but maybe it works fine for GNOME users

Closes #248285

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fgaz fgaz mentioned this pull request Apr 9, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others lgtm, runs fine, can't record because I'm using hyprland :(

=> tree ./result/ -a
./result/
├── bin
│   ├── wayfarer
│   └── .wayfarer-wrapped
└── share
    ├── applications
    │   └── org.stronnag.wayfarer.desktop
    ├── glib-2.0
    ├── gsettings-schemas
    │   └── wayfarer-1.2.4
    │       └── glib-2.0
    │           └── schemas
    │               ├── gschemas.compiled
    │               └── org.stronnag.wayfarer.gschema.xml
    └── icons
        └── hicolor
            └── scalable
                └── apps
                    └── wayfarer.svg

@Aleksanaa
Copy link
Member

Aleksanaa commented Apr 12, 2024

Have you got anyone to test this? A friend of mine who uses gnome45 (nixos-unstable branch) said he couldn't use the screen recorder, but he didn't find any meaningful errors.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 302772 run on x86_64-linux 1

1 package built:
  • wayfarer

@Scrumplex
Copy link
Member

Also doesn't work for me on Sway. It logs pipewiresrc link fails

@fgaz
Copy link
Member Author

fgaz commented Apr 12, 2024

I added pipewire to buildInputs and that fixed it for me. I wonder why I didn't get any warning during configurePhase.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 302772 run on x86_64-linux 1

1 package built:
  • wayfarer

@Scrumplex
Copy link
Member

Works on Sway!

@Aleksanaa Aleksanaa merged commit a811284 into NixOS:master Apr 13, 2024
24 checks passed
@fgaz fgaz deleted the wayfarer/init branch April 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: wayfarer
4 participants