Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

brainstem: init at 2.10.5 #302833

Merged
merged 1 commit into from Apr 10, 2024
Merged

brainstem: init at 2.10.5 #302833

merged 1 commit into from Apr 10, 2024

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 9, 2024

This provides a library and CLI tools to control Acroname USB Smart switches, as well as a firmware updater.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

This provides a library and CLI tools to control Acroname USB Smart
switches, as well as a firmware updater.
Copy link
Contributor

@SomeoneSerge SomeoneSerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant nits:

I'd use nixfmt-rfc-style (because why not) and I'd generally write "''${!outputDev}" (Bin, Doc, Lib) instead of $dev (etc) so the phases are agnostic of outputs. Obviously it doesn't matter in this PR, but I think it's a reasonable default

pkgs/by-name/br/brainstem/package.nix Show resolved Hide resolved
@flokli
Copy link
Contributor Author

flokli commented Apr 10, 2024

From the irrelevant nits section:

I'd use nixfmt-rfc-style (because why not)

I have nixpkgs-fmt in my editor currently still. If there's a tree-wide policy in place, it'll probably be reformatted anyways.

and I'd generally write "''${!outputDev}" (Bin, Doc, Lib) instead of $dev (etc) so the phases are agnostic of outputs. Obviously it doesn't matter in this PR, but I think it's a reasonable default

There's 58 files in nixpkgs containing outputDev, and 182 containing $dev/include alone. I personally prefer to stick with the other style.

@flokli flokli merged commit 1a948a4 into NixOS:master Apr 10, 2024
29 of 30 checks passed
@flokli flokli deleted the brainstem branch April 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants