nixos/oauth2_proxy: add oidc-issuer-url flag #303224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break oauth2_proxy for every existing user with the message: Is that intentional? If so, I think a release note with migration instructions is warranted. |
0z13
force-pushed
the
oauth2_proxy-add-issuer-url
branch
from
921bfc2
to
970dc0f
Compare
|
Sorry i was being careless, that's not my intention. 😅 Added a default value. Thanks for catching this. |
0z13
force-pushed
the
oauth2_proxy-add-issuer-url
branch
from
2c2ba30
to
87bbc5f
Compare
cafkafk
approved these changes
Apr 19, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some providers are broken after 7.3, and you'll need to use the oidc-issuer-url flag now. see oauth2-proxy/oauth2-proxy#1666
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.