Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avrdude: updates and enablement of compile-time features #303276

Merged
merged 8 commits into from
Apr 20, 2024

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Apr 11, 2024

Description of changes

Sort of a smörgåsbord.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3774

@philiptaron
Copy link
Contributor Author

Testing it out on aarch64-darwin also.

@philiptaron philiptaron force-pushed the avrdude-libelf branch 3 times, most recently from facd3e9 to ec418b6 Compare April 11, 2024 20:37
@philiptaron philiptaron changed the title avrdude: use elfutils or vendored libelf instead of abandoned upstream avrdude: updates and enablement of compile-time features Apr 11, 2024
@philiptaron philiptaron marked this pull request as ready for review April 11, 2024 20:43
@philiptaron
Copy link
Contributor Author

Sorry for the multiple pushes. I happened to get caught by #303244 doing the same thing as one of my commits.

@bjornfor, @SuperSandro2000, I think this is ready for review now.

@philiptaron
Copy link
Contributor Author

@funkeleinhorn, as a user of the avrdude set of tools, appreciate your review and testing as well. Thanks.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits look good. Didn't test.

@philiptaron
Copy link
Contributor Author

Thanks for the reviews @bjornfor and @SuperSandro2000. Updated per comments.

@ofborg ofborg bot requested a review from bjornfor April 15, 2024 16:48
@SuperSandro2000
Copy link
Member

I've squashed the two review commits into the initial ones.

@SuperSandro2000 SuperSandro2000 merged commit e8d09f9 into NixOS:master Apr 20, 2024
6 of 7 checks passed
@philiptaron philiptaron deleted the avrdude-libelf branch April 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants