plover.dev: 4.0.0.dev10 -> 4.0.0rc2 #303669

FirelightFlagboy · 2024-04-12T17:40:58Z

Description of changes

This updates the Plover development version to 4.0.0.rc2.

I was having an issue first when build the project without pyproject = true.

The error was Requirements should be satisfied by a PEP 517 installer.
With pyproject enabled, 2 dependencies were missing: plover_stroke and rtf_tokenize.
postPatch step was removed since the setup.cfg file no longer specify PyQt5.

Things done

Add a 👍 reaction to pull requests you find important.

FirelightFlagboy · 2024-04-24T07:24:27Z

Hello @Twey and @KoviRobi, I would like to know if you can review this PR as you're currently set as maintainers of plover.dev 😃

KoviRobi · 2024-04-24T07:46:56Z

Thank you for the reminder, I'll try to set some time aside this evening

KoviRobi · 2024-04-27T16:13:23Z

Thank you for your contribution -- I've tested and it works. I've left a few minor comments. I'm not a core maintainer (or whatever the word is) so I cannot approve but having someone look over it should make that process faster.

I think once you have had a look at the comments, the next step is to post the PR into https://discourse.nixos.org/t/prs-ready-for-review/3032/3831

KoviRobi · 2024-04-27T15:21:14Z

pkgs/applications/misc/plover/default.nix


    meta = with lib; {
+      mainProgram = "plover";
      broken = stdenv.isDarwin;


Given the above you have darwin in platforms, were you able test on it? If so can this broken be removed?

No I'm not able to test on darwin platforms.

For the previous packages (plover_stroke and rtf_tokenize) should I've only listed the platforms that I've tested ?

Given these packages are inaccessible outside of plover (i.e. can't just nix build nixpkgs#plover.plover_stroke or similar) perhaps there is no need to have darwin in the list.

I'm not that knowledgeable about all the maintenance burdens and intricacies of packaging, but I believe there are two conflicting goals: one is offer as large set of available packages as possible, to make it an attractive offering as possible, the other is to minimize broken packages.

If we don't mark a package as working when it isn't people might not have the confidence to try building and then contribute a patch saying it's working (perhaps adding themselves to the maintainer list to get notified if it is updated in the future, to test it on their systems too). Given nix is already technically challenging, perhaps we could be fine with this.

Also, hydra won't have prebuilt binaries, not a huge problem for quick to build packages though.

On the maintenance side though, if we mark a package as working when it isn't, it's going to present as a failure which will increase maintenance burden (tracking down why it's failed, getting hold of the system on which it's failed). These probably outweigh the maintenance required to approve PRs adding to the supported systems.

So I would just stick with smaller list of known supported systems here, though what I'm trying to say is, it's not a case of one is strictly better than the other here. I've had a quick look in https://nixos.org/nixpkgs/manual and in README.md/pkgs/README.md and couldn't find advice on which to prefer.

As you suggested, I've removed platform.darwin from the intermediate packages.

KoviRobi · 2024-04-27T15:29:47Z

pkgs/applications/misc/plover/default.nix

    pname = "plover";
-    version = "4.0.0.dev10";
+    version = "4.0.0.dev12";


dev12 is from 2022-08-08, any reason for not using the latest pre-release? The 4.0.0rc2+6.g53c416f release is using a tag "continuous" which sounds like it might be deleted/renamed, so maybe not that one, but v4.0.0rc2 should work

The current pattern for plover on nixpkgs is plover.stable (deprecated) and plover.dev.

Since it's my first contribution to nixpkgs I wanted to start with something simple and providing the v4.0.0-rc.2 would have required to add a new derivation for plover.rc (by following the previous pattern) (but I may provide a PR for that version in the future).

Instead I've choose to provide an update for plover.dev even tho it's an old version (2022) to take a hands-on the PR process of nixpkgs.

Ah I see, I don't think you'd need to add a new derivation plover.rc, I think plover.dev would be fine with a release candidate version -- I think the distinction is full/stable releases vs development releases, and a release candidate I would say is a development release (on its way to being a full release though).

The other way of looking at it is, I don't believe v4.0.0rc2 breaks anything new that v4.0.0dev10 or v4.0.0dev12 doesn't already break.

I.e. both have the following

Warning: Version 4 is a major change and the configuration file it creates is not compatible with Plover 3 or earlier. Please backup your plover.cfg

and this might be the reason for plover.stable vs plover.dev, but it's not a reason to have plover.dev vs plover.rc if this makes sense.

So upgrading to v4.0.0rc2 but keeping it under plover.dev should be fine.

I've added a commit to update to 4.0.0-rc.2 \(^^)/

pkgs/applications/misc/plover/default.nix

FirelightFlagboy

Thanks you for your review @KoviRobi, I'll try to make a post on discourse

FirelightFlagboy · 2024-04-28T08:28:59Z

pkgs/applications/misc/plover/default.nix

    pname = "plover";
-    version = "4.0.0.dev10";
+    version = "4.0.0.dev12";


The current pattern for plover on nixpkgs is plover.stable (deprecated) and plover.dev.

Since it's my first contribution to nixpkgs I wanted to start with something simple and providing the v4.0.0-rc.2 would have required to add a new derivation for plover.rc (by following the previous pattern) (but I may provide a PR for that version in the future).

Instead I've choose to provide an update for plover.dev even tho it's an old version (2022) to take a hands-on the PR process of nixpkgs.

pkgs/applications/misc/plover/default.nix

FirelightFlagboy · 2024-04-28T08:33:00Z

pkgs/applications/misc/plover/default.nix


    meta = with lib; {
+      mainProgram = "plover";
      broken = stdenv.isDarwin;


No I'm not able to test on darwin platforms.

For the previous packages (plover_stroke and rtf_tokenize) should I've only listed the platforms that I've tested ?

nixos-discourse · 2024-04-28T08:48:20Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3839

This updates the Plover development version to 4.0.0.dev12. - I was having an issue first when build the project without `pyproject = true`. Indicating that `Requirements should be satisfied by a PEP 517 installer.` - With `pyproject` enabled, 2 dependencies were missing: `plover_stroke` and `rtf_tokenize`. - `postPatch` step was removed since the `setup.cfg` file no longer specify `PyQt5`.

pkgs/applications/misc/plover/default.nix

FirelightFlagboy · 2024-06-10T08:13:58Z

@SuperSandro2000 thanks for the review, I've applied your suggestions:

Moving meta at the end of the derivations.
Directly using the version value instead of stringify it another time.
Move nativeCheckInputs after *BuildInputs.
Using pytestCheckHook instead of pytest in nativeCheckInputs.

For the fixup commits, I'll squash them later

SuperSandro2000 · 2024-06-10T10:09:28Z

pkgs/applications/misc/plover/default.nix

+    propagatedBuildInputs = [
+      babel
+      pyqt5
+      qt5.qtwayland


We probably want to place qtwayland only in buildInputs. It will then be used by the wrapper and we don't propagate unnecessary libraries by accident.

NixOSInfra added the 12. first-time contribution label Apr 12, 2024

ofborg bot requested a review from KoviRobi April 12, 2024 18:09

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 12, 2024

FirelightFlagboy force-pushed the update-plover-4.0.0.dev12 branch from 1a0e09a to 5a1d423 Compare April 13, 2024 13:41

KoviRobi reviewed Apr 27, 2024

View reviewed changes

FirelightFlagboy commented Apr 28, 2024

View reviewed changes

ofborg bot requested a review from KoviRobi April 28, 2024 09:00

ofborg bot added the 11.by: package-maintainer label Apr 28, 2024

maintainers: add FirelightFlagboy

8aacc24

FirelightFlagboy force-pushed the update-plover-4.0.0.dev12 branch from eb1ac24 to 73eac0a Compare April 28, 2024 09:27

FirelightFlagboy added 2 commits April 29, 2024 08:18

plover.dev: 4.0.0.dev12 -> 4.0.0rc2

83c4b43

FirelightFlagboy force-pushed the update-plover-4.0.0.dev12 branch from 73eac0a to 83c4b43 Compare April 29, 2024 06:18

FirelightFlagboy changed the title ~~plover.dev: 4.0.0.dev10 -> 4.0.0.dev12~~ plover.dev: 4.0.0.dev10 -> 4.0.0.rc2 Apr 29, 2024

FirelightFlagboy changed the title ~~plover.dev: 4.0.0.dev10 -> 4.0.0.rc2~~ plover.dev: 4.0.0.dev10 -> 4.0.0rc2 Apr 29, 2024

SuperSandro2000 reviewed Jun 2, 2024

View reviewed changes

FirelightFlagboy added 3 commits June 10, 2024 10:06

fixup! plover.dev: 4.0.0.dev12 -> 4.0.0rc2

ee20e42

fixup! plover.dev: 4.0.0.dev12 -> 4.0.0rc2

d757c51

fixup! plover.dev: 4.0.0.dev12 -> 4.0.0rc2

c6253fe

github-actions bot added the 8.has: maintainer-list (update) label Jun 10, 2024

FirelightFlagboy requested a review from SuperSandro2000 June 10, 2024 08:11

SuperSandro2000 reviewed Jun 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plover.dev: 4.0.0.dev10 -> 4.0.0rc2 #303669

plover.dev: 4.0.0.dev10 -> 4.0.0rc2 #303669

FirelightFlagboy commented Apr 12, 2024 •

edited

FirelightFlagboy commented Apr 24, 2024

KoviRobi commented Apr 24, 2024

KoviRobi commented Apr 27, 2024 •

edited

KoviRobi Apr 27, 2024

FirelightFlagboy Apr 28, 2024

KoviRobi Apr 28, 2024

FirelightFlagboy Apr 29, 2024

KoviRobi Apr 27, 2024

FirelightFlagboy Apr 28, 2024

KoviRobi Apr 28, 2024

FirelightFlagboy Apr 29, 2024 •

edited

FirelightFlagboy left a comment

FirelightFlagboy Apr 28, 2024

FirelightFlagboy Apr 28, 2024

nixos-discourse commented Apr 28, 2024

FirelightFlagboy commented Jun 10, 2024

SuperSandro2000 Jun 10, 2024

plover.dev: 4.0.0.dev10 -> 4.0.0rc2 #303669

Are you sure you want to change the base?

plover.dev: 4.0.0.dev10 -> 4.0.0rc2 #303669

Conversation

FirelightFlagboy commented Apr 12, 2024 • edited

Description of changes

Things done

FirelightFlagboy commented Apr 24, 2024

KoviRobi commented Apr 24, 2024

KoviRobi commented Apr 27, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FirelightFlagboy Apr 29, 2024 • edited

Choose a reason for hiding this comment

FirelightFlagboy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nixos-discourse commented Apr 28, 2024

FirelightFlagboy commented Jun 10, 2024

Choose a reason for hiding this comment

FirelightFlagboy commented Apr 12, 2024 •

edited

KoviRobi commented Apr 27, 2024 •

edited

FirelightFlagboy Apr 29, 2024 •

edited