c3c: add version check #304409
Open
c3c: add version check #304409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numinit
reviewed
Apr 16, 2024
numinit
approved these changes
Apr 25, 2024
|
@ofborg build c3c |
eclairevoyant
requested changes
Jun 1, 2024
causes a warning when we try to use lib.getExe in later commits
tomodachi94
force-pushed
the
enhance/c3c/add-testVersion
branch
from
70351a5
to
c536552
Compare
|
Latest push fixes the merge conflicts, as well as migrating the package to the |
| passthru.tests = { | ||
| version = testers.testVersion { | ||
| package = finalAttrs.finalPackage; | ||
| command = "${lib.getExe finalAttrs.finalPackage} --version"; |
There was a problem hiding this comment.
command can be omitted here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a simple
testers.testVersiontest to ensure this package's binaries function, hopefully enabling for quicker updates and better quality assurance for this package.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.